-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasi] Add wasi-experimental
workload, wasiconsole
template, and Wasi.Build.Tests
#81849
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm-optional |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run runtime-wasm-optional |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run runtime-wasm-optional |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm-optional |
Azure Pipelines successfully started running 1 pipeline(s). |
59e1b48
to
152d9e8
Compare
526c3cd
to
4d0f7fe
Compare
wasi-experimental
workload, wasiconsole
template, and Wasi.Build.Tests
- And Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk
07bf0ee
to
3e1b18d
Compare
<LibrariesRuntimeFiles | ||
Include=" | ||
$(LibrariesNativeArtifactsPath)dotnet.wasm; | ||
$(LibrariesNativeArtifactsPath)dotnet.timezones.blat; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will clash here with my PR on dotnet.timezones.blat;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't be merged before the snap, correct? You can change it once this is merged as you see fit.
...ono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/WorkloadManifest.targets.in
Show resolved
Hide resolved
@@ -0,0 +1,95 @@ | |||
// Licensed to the .NET Foundation under one or more agreements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe wasi host should be separate project and separate host.
There are dependencies which don't make sense for WASI like BrowserDebugHost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can discuss that. For now I want to have a single WasmAppHost which can run any of the projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will depend on how we decide to eventually compose the workloads.
Failure is unrelated, and known. |
Wasi.Build.Tests
, with some duplicated code between Wasi, and Wasm build tests. This is being cleaned in a separate branch for a follow up PRwasiconsole
templatewasmtime